fix(proto): Fixed types encoding #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aelesbao The lints seem to be outdated. Its not detecting the latest clippy lints. |
aelesbao
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an assumption that serde was correlated with proto encoding. The tests passed since they verified that serde serialization worked which was true. This new update adds proto encoding testing along with two major changes.
abstract-anywere moved from being justTtoAny<T>. The reason for this is that proto has to support for adding custom generic encoding/decoding techniques, making generating this very hard to do. This could be reserved for a future update, but for current requirements its not needed.GenericDatatype. When dealing with a response that may have an array of different types, for exampleQueryAccountsResponse<BaseAccount<_>>inside theAuthmodule doesn't work because it can also containModuleAccount<_>andIcaAccount<_>, replacing this withQueryAccountsResponse<GenericData>and validating eachAny::type_urlto determine what to decode into.