Fixed session support #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [ipython](https://github.com/ipython/ipython) from 7.18.1 to 8.10.0. - [Release notes](https://github.com/ipython/ipython/releases) - [Commits](ipython/ipython@7.18.1...8.10.0) --- updated-dependencies: - dependency-name: ipython dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
In order to support proxies, shared session tokesn, and other authorization schemes, this commit supports supplying either username/password as before OR a session_token argument/config key.
bonniegee
reviewed
Apr 1, 2024
|
|
||
| An example .archivessnake.yml file: | ||
| An minimal example of an .archivessnake.yml file: |
There was a problem hiding this comment.
This is very minor, but "an" should be changed to "a."
| | `retry_with_auth` | Whether to respond to 403 errors by trying to authorize and retrying | True | | ||
| | `logging_config` | Hash with various config values for the logging subsystem | **see below** | | ||
|
|
||
| `username`/`password` and `session_token` are mutually exclusive. In a normally configured ArchivesSpace system, you will want to use `username`/`password`. `session_token` allows you to set a fixed value for the session, in case you are sharing a long-lived session amongst several apps, or using an authorization customization that bypasses the ArchivesSpace login route. Examples of this include proxies or SSO plugins. `session_header_name` lets you customize the header you pass the session in, since some proxies use a different header than `X-ArchivesSpace-Session`. |
There was a problem hiding this comment.
It might be worth being more explicit that a config file can't have a username and a session token. A user may expect behavior such as one being used by default, or being able to choose the authorization method while running ArchivesSnake. I don't think either are necessary, but it might make sense to be explicit here.
| log.debug('argument error in authorize') | ||
| raise ASnakeAuthError("Cannot set both username/password and session_token") | ||
|
|
||
| session_header_name = session_header_name or self.config['session_header_name'] |
There was a problem hiding this comment.
Should this be self.config.get('session_header_name', None)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates ASnake to support directly providing a session token in configuration or as an argument to the client/abstraction layer constructors. This is intended to provide support for the following use cases