Delete forge mods' jarjar metadata #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shedaniel
added
bug
Test Results 90 files ±0 1 errors 89 suites ±0 4h 5m 57s ⏱️ + 1h 4m 43s For more details on these parsing errors, see this check. Results for commit 110aa18. ± Comparison against base commit 7a26b37. ♻️ This comment has been updated with latest results. |
Juuxel
reviewed
Aug 28, 2023
Juuxel
approved these changes
Sep 3, 2023
Co-authored-by: Juuz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be consistent with how Loom handles Fabric jars with JIJ, prevents artifacts with JIJ mods from crashing in game due to it not being remapped.
This is not tested yet. I will update this comment when it is.