Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Neo #154

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Support Neo #154

merged 1 commit into from
Aug 8, 2023

Conversation

shedaniel
Copy link
Member

image

Instructions

  • Use forge "net.neoforged:forge:VERSION"
  • Add maven { url "https://maven.neoforged.net/releases/" } to build.gradle repositories and settings.gradle

@shedaniel shedaniel added priority: low This does not immediately need to be resolved small change This PR introduces a small change and may be merged without an extensive 'last call' period. Forge This issue is specific to the Forge platform. labels Aug 8, 2023
@shedaniel shedaniel requested a review from Juuxel August 8, 2023 19:09
Copy link
Member

@Juuxel Juuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, LGTM. There's a little refactor I want to do later to clean up the dep string matching code, we duplicate it in many places.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Test Results

  90 files  ±  0      1 errors  89 suites   - 1   3h 48m 24s ⏱️ - 1h 54m 51s
487 tests  - 60  486 ✔️  - 60  1 💤 ±0  0 ±0 
490 runs   - 58  489 ✔️  - 58  1 💤 ±0  0 ±0 

For more details on these parsing errors, see this check.

Results for commit 7ba2506. ± Comparison against base commit e0efe9c.

This pull request removes 84 and adds 13 tests. Note that renamed tests count towards both.

 '
Fabric-Loom-Remap: broken
Fabric-Loom-Remap: false
Fabric-Loom-Remap: true
Something: Hello
], #1]
], #2]
], #3]
], #4]
…
net.fabricmc.loom.test.integration.DecompileTest ‑ cfr gradle 8.1
net.fabricmc.loom.test.integration.DecompileTest ‑ fernflower gradle 8.1
net.fabricmc.loom.test.integration.UnpickTest ‑ unpick build [version: 8.1, #0]
net.fabricmc.loom.test.integration.UnpickTest ‑ unpick decompile [version: 8.1, #0]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: false, entries: [fabric.mod.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: false

], #2]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: false, entries: [hello.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: broken

], #6]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: false, entries: [hello.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: false

], #4]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: false, entries: [hello.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Something: Hello

], #7]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: true, entries: [fabric.mod.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: true

], #3]
net.fabricmc.loom.test.unit.ArtifactMetadataTest ‑ Should Remap [shouldRemap: true, entries: [hello.json:{}, META-INF/MANIFEST.MF:Manifest-Version: 1.0
Fabric-Loom-Remap: true

], #5]
…

@shedaniel shedaniel merged commit 7a26b37 into dev/1.2 Aug 8, 2023
89 of 92 checks passed
@shedaniel shedaniel deleted the feature/neo-support branch August 8, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Forge This issue is specific to the Forge platform. priority: low This does not immediately need to be resolved small change This PR introduces a small change and may be merged without an extensive 'last call' period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants