Close #236 #242
Open
Close #236 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shedaniel
added
enhancement
|
Is there anything that i can do to help with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the flammable registry to allow mods register their blocks as flammable, this PR is currently not tested, test mod pending!
I am not sure if the fabric flammable registry's default instance is applicable to all fire blocks, probably not, so that needs to be look into and tested as well.
I am wary of the performance issues by looking up the near by fire block,
but vanilla fires are already laggy, and I can't think of a better way to implement this.We need to inject to an interface, thus the custom ASM we have here.