Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upper bound on urllib3 (<2) #9826 #9827

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Add upper bound on urllib3 (<2) #9826 #9827

merged 1 commit into from
Jul 25, 2023

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Jul 25, 2023 •
edited
Loading

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

requests lifted its upper bound of urllib3 from <1.26 to <3 in 2.30.0, but this conflicts with elastic-transport's upper bound of <2. Add this upper bound back.

Lets pip install -r arches/install/requirements.txt succeed.

Issues Solved

Closes #9826

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

@jacobtylerwalls
Add upper bound on urllib3 (<2) archesproject#9826
ec270e4 
`requests` lifted its upper bound from <1.26 to <3
in 2.30.0, but this conflicts with `elastic-transport`'s
upper bound of <2.
@CLAassistant
Copy link

CLAassistant commented Jul 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@chiatt chiatt self-requested a review July 25, 2023 17:58
@chiatt chiatt self-assigned this Jul 25, 2023
chiatt
chiatt approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chiatt chiatt merged commit a47c7c0 into archesproject:dev/7.4.x Jul 25, 2023
1 check passed
@jacobtylerwalls jacobtylerwalls deleted the urllib3-upper-bound branch July 25, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiatt chiatt chiatt approved these changes

Assignees

@chiatt chiatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobtylerwalls @CLAassistant @chiatt