Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11591 cbyrd remove declarations.d.ts testing #11598

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

chrabyrd
Copy link
Contributor

@chrabyrd chrabyrd commented Oct 31, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

TO TEST:

  1. on dev/8.0.x, create a project
  2. ensure the instance of Arches it's pointing to does not have a tsconfig-paths.json file
  3. run npm run vitest
  4. notice the error mentioned in ignore declarations.d.ts file for testing/code coverage purposes, remove sample code from project generation templates #11591
  5. run updateproject, or create a new project when checked out into this branch
  6. run npm run vitest
  7. notice the error no longer appears

Issues Solved

Closes #11591

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested, including:

  • updateproject
  • vitest tests still pass on a project with some front end tests
  • python tests still run, give expected NO TESTS RAN with exit code 0

@chrabyrd chrabyrd merged commit 7243ae3 into dev/8.0.x Oct 31, 2024
5 checks passed
@chrabyrd chrabyrd deleted the 11591-cbyrd-remove-declarations.d.ts-testing branch October 31, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants