Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ACCESSIBILITY_MODE on base-root.htm #11326 #11327

Closed
wants to merge 1 commit into from
Closed

Expose ACCESSIBILITY_MODE on base-root.htm #11326 #11327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion arches/app/templates/base-root.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,11 @@
{% endblock head %}

{% block body_content %}
<body dir="{{ app_settings.ACTIVE_LANGUAGE_DIR }}" {% block body_attributes %}class="scroll-y-auto"{% endblock %}>
<body
dir="{{ app_settings.ACTIVE_LANGUAGE_DIR }}"
accessibility-mode="{{ app_settings.ACCESSIBILITY_MODE }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the plan on consuming this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not that much of an improvement, but it avoids checking a hard-coded stylesheet name: archesproject/arches-references@8fb0c0b.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Is shouldUseContrast still going to be used once basic theming is stubbed out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless/until we get buy-in to deprecate that recently added setting, I think projects will still want a way to switch between theming that uses more colors versus theming that passes WCAG AA color contrast with a much more restricted palette. Happy to chat offline if you have other ideas!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just documenting here the result of our conversation yesterday: Since theming/theme-switching is being moved into core, likely the entire interaction could take place within a different pattern than this. From my understanding we're pausing this until that lands 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, will close PR but won't delete the branch just yet in case we decide we want to demo this for any reason.

{% block body_attributes %}class="scroll-y-auto"{% endblock %}
>
{% block loading_mask %}
{% endblock loading_mask %}

Expand Down