Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove controlled list manager and reference datatype #11209

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Remove controlled list manager and reference datatype #11209

merged 3 commits into from
Jul 19, 2024

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Jul 18, 2024 •
edited
Loading

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

8.0 is 9 months out. In the meantime, as part of #11201, we'll be exploring the idea of publishing the Controlled List Manager & reference datatype as an arches application maintained outside of the core arches repository.

Thus, the work merged in #10569 needs to be reverted.

A separate commit maintains some useful changes that were mixed in with that work and can be merged down into 7.6. Some (but not all) of those changes would be necessary if we decide that the controlled list manager will support 7.6.

Follow-up PR to discuss that: #11210

Issues Solved

Refs #11201

@jacobtylerwalls jacobtylerwalls mentioned this pull request Jul 18, 2024
Merged
@chrabyrd chrabyrd self-requested a review July 19, 2024 18:21
chrabyrd
chrabyrd approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@chrabyrd chrabyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jacobtylerwalls jacobtylerwalls merged commit fde070f into dev/8.0.x Jul 19, 2024
6 of 7 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/remove-controlled-lists branch July 19, 2024 18:23
@jacobtylerwalls jacobtylerwalls removed the request for review from johnatawnclementawn July 19, 2024 18:23
johnatawnclementawn added a commit to archesproject/arches-references that referenced this pull request Jul 23, 2024
@johnatawnclementawn
Move frontend from core Arches archesproject/arches#11209
efa30f5
johnatawnclementawn added a commit to archesproject/arches-references that referenced this pull request Jul 23, 2024
@johnatawnclementawn
Add datatype tests for reference datatype re. archesproject/arches#11209
c299f8f
@johnatawnclementawn johnatawnclementawn mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrabyrd chrabyrd chrabyrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Controlled List Manager
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @chrabyrd