Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controlled list manager second iteration #10670

Merged
merged 32 commits into from
Mar 15, 2024
Merged

Controlled list manager second iteration #10670

merged 32 commits into from
Mar 15, 2024

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Mar 8, 2024 •
edited
Loading

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Issues Solved

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

@jacobtylerwalls
Show items with <Tree>
4e4eb3e
@jacobtylerwalls
Add action buttons beneath list read only component
f7a8597
@jacobtylerwalls
Add expand, collapse, language controls
1bac710
@jacobtylerwalls
Show referencing nodes
35f87cf
@jacobtylerwalls
Improve error message
6b47885
@jacobtylerwalls
Add search_only and guide fields #10602
18177b3
@jacobtylerwalls
Show list as top node of list tree
d16534b
@jacobtylerwalls
Add icons to item rows
d7d7ca1
@jacobtylerwalls
Rough out item/list editor switch
f7994e2
@jacobtylerwalls
Various refactors/fixes
2411b81
@jacobtylerwalls
Remove "ReadOnly" component
62be926
@jacobtylerwalls
Move navigation buttons
233fa7f
@jacobtylerwalls
Make <SidepanelDataView> single-purpose
4ad8d2f
@jacobtylerwalls
fixup! Reduce
e9b8dee
@jacobtylerwalls
fixup! Avoid arches.translations
709248e
@jacobtylerwalls
Adjust button border after primevue stylesheet swap
de3e003
@jacobtylerwalls
Improve height, overflow
e1a4c8d
@jacobtylerwalls
Improve delete label pluralization, remove cruft
0399c0c
@jacobtylerwalls
Style nits
fa659db
@jacobtylerwalls
Show item label in item editor header
9b2bad5
@jacobtylerwalls
Add item type to item header
442e2e8
@jacobtylerwalls
Remove toast life
8c51261
@jacobtylerwalls jacobtylerwalls changed the title [WIP] Controlled list item editor second iteration [WIP] Controlled list editor second iteration Mar 8, 2024
@jacobtylerwalls jacobtylerwalls force-pushed the controlled-list-item-editor-second-iteration branch from 572261a to 8fb01a5 Compare March 11, 2024 15:35
@jacobtylerwalls jacobtylerwalls changed the title [WIP] Controlled list editor second iteration Controlled list editor second iteration Mar 11, 2024
@jacobtylerwalls jacobtylerwalls marked this pull request as ready for review March 11, 2024 15:58
@jacobtylerwalls jacobtylerwalls changed the title Controlled list editor second iteration Controlled list manager second iteration Mar 14, 2024
@jacobtylerwalls jacobtylerwalls force-pushed the controlled-list-item-editor-second-iteration branch from 610d987 to 12ce561 Compare March 15, 2024 19:06
@jacobtylerwalls jacobtylerwalls force-pushed the controlled-list-item-editor-second-iteration branch from 12ce561 to b3c30f4 Compare March 15, 2024 19:07
@jacobtylerwalls jacobtylerwalls merged commit 3c4084d into controlled-list-item-editor Mar 15, 2024
1 of 4 checks passed
@jacobtylerwalls jacobtylerwalls deleted the controlled-list-item-editor-second-iteration branch March 15, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jacobtylerwalls