Update activity stream, #9768, #9769 #10662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 25, 2024
jacobtylerwalls
approved these changes
Mar 25, 2024
| @@ -228,9 +228,11 @@ def save(self, *args, **kwargs): | |||
| context = kwargs.pop("context", None) | |||
| transaction_id = kwargs.pop("transaction_id", None) | |||
| super(Resource, self).save(*args, **kwargs) | |||
| self.save_edit(user=user, edit_type="create", transaction_id=transaction_id) | |||
There was a problem hiding this comment.
I think as the ticket author pointed out it's possible that moving this call to solve #9769 is not necessary if we do the filtering in #9768 as in this PR, but I still like the idea of doing it in case the another caller somewhere else in the application chooses not to filter in the same precise way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
Update the active stream view not to returns "Update" (such as tile create) when the tiles are created with the resource creation.
Issues Solved
#9768, #9769
Checklist
Ticket Background
Further comments