Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial models, UI components for controlled list manager #10541 #10544

Closed
wants to merge 14 commits into from

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Jan 19, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Add initial models, UI components for a Controlled List Manager

Run migrations; then, to import some sample test data into your local db:

PYTHONPATH="../arches" python3 manage.py shell -c "from tests.views.controlled_lists_tests import ControlledListTests; ControlledListTests.setUpTestData()"

@chiatt @chrabyrd 👋 eager for feedback while the ink is still wet!

Issues Solved

Closes #10541

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

Allows raising a 403 PermissionDenied for AJAX-style
requests, instead of a 302 redirect to nowhere.
@jacobtylerwalls jacobtylerwalls linked an issue Jan 19, 2024 that may be closed by this pull request
Copy link
Contributor

@chrabyrd chrabyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will go through this more thoroughly later, but wanted to get a blocking issue in to refactor to TS once #10522 is merged

@jacobtylerwalls jacobtylerwalls changed the base branch from dev/7.6.x to dev/8.0.x January 26, 2024 19:20
@jacobtylerwalls jacobtylerwalls deleted the controlled-list-manager-tweaks branch February 1, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Controlled List Manager
3 participants