nit re #10541, rewrite multi-line ternaries

archesproject · May 15, 2024 · e574324 · e574324
1 parent b0840c9
commit e574324
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 10 deletions.
diff --git a/arches/app/src/components/ControlledListManager/AddLabel.vue b/arches/app/src/components/ControlledListManager/AddLabel.vue
@@ -25,9 +25,14 @@ const { $gettext } = useGettext();
 const slateBlue = "#2d3c4b"; // todo: import from theme somewhere
 
 const buttonLabel = computed(() => {
-    return props.type === "prefLabel"
-        ? $gettext("Add Preferred Label")
-        : $gettext("Add Alternate Label");
+    switch (props.type) {
+        case "prefLabel":
+            return $gettext("Add Preferred Label");
+        case "altLabel":
+            return $gettext("Add Alternate Label");
+        default:
+            throw new Error();
+    }
 });
 </script>
 

diff --git a/arches/app/src/components/ControlledListManager/ItemCharacteristic.vue b/arches/app/src/components/ControlledListManager/ItemCharacteristic.vue
@@ -50,9 +50,8 @@ const onSave = () => {
     // eslint-disable-next-line vue/no-mutating-props
     props.item[props.field] = dirtyFormValue.value;
 
-    const saveFn = Object.hasOwn(props.item, "items")
-        ? postListToServer
-        : postItemToServer;
+    const isList = Object.hasOwn(props.item, "items");
+    const saveFn = isList ? postListToServer : postItemToServer;
     saveFn(props.item, toast, $gettext);
 };
 const onCancel = () => {

diff --git a/arches/app/src/components/ControlledListManager/LabelRow.vue b/arches/app/src/components/ControlledListManager/LabelRow.vue
@@ -18,11 +18,15 @@ const visible = ref(false);
 
 const { $gettext } = useGettext();
 const header = computed(() => {
-    return props.label.valuetype === "prefLabel"
-        ? $gettext("Edit Preferred Label")
-        : $gettext("Edit Alternate Label");
+    switch (props.label.valuetype) {
+        case "prefLabel":
+            return $gettext("Edit Preferred Label");
+        case "altLabel":
+            return $gettext("Edit Alternate Label");
+        default:
+            throw new Error();
+    }
 });
-
 </script>
 
 <template>