Extract string constants

archesproject · Mar 8, 2024 · 8a01d36 · 8a01d36
1 parent 8c51261
commit 8a01d36
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 10 deletions.
diff --git a/arches/app/src/components/ControlledListManager/AddLabel.vue b/arches/app/src/components/ControlledListManager/AddLabel.vue
@@ -5,6 +5,8 @@ import { useGettext } from "vue3-gettext";
 
 import EditLabel from "@/components/ControlledListManager/EditLabel.vue";
 
+import { ALT_LABEL, PREF_LABEL } from "@/components/ControlledListManager/const.ts";
+
 import type {
     ControlledListItem,
     Label,
@@ -35,9 +37,9 @@ const newLabel: NewLabel = computed(() => {
 
 const buttonLabel = computed(() => {
     switch (props.type) {
-        case "prefLabel":
+        case PREF_LABEL:
             return $gettext("Add Preferred Label");
-        case "altLabel":
+        case ALT_LABEL:
             return $gettext("Add Alternate Label");
         default:
             throw new Error();

diff --git a/arches/app/src/components/ControlledListManager/ItemEditor.vue b/arches/app/src/components/ControlledListManager/ItemEditor.vue
@@ -5,6 +5,7 @@ import { useGettext } from "vue3-gettext";
 import ItemCharacteristic from "@/components/ControlledListManager/ItemCharacteristic.vue";
 import LabelEditor from "@/components/ControlledListManager/LabelEditor.vue";
 
+import { ALT_LABEL, PREF_LABEL, URI } from "@/components/ControlledListManager/const.ts";
 import { bestLabel } from "@/components/ControlledListManager/utils.ts";
 
 import type { Language } from "@/types/arches";
@@ -61,11 +62,11 @@ const iconLabel = (item: ControlledListItem) => {
     </span>
     <LabelEditor
         :item
-        type="prefLabel"
+        type="PREF_LABEL"
     />
     <LabelEditor
         :item
-        type="altLabel"
+        type="ALT_LABEL"
     />
     <LabelEditor
         :item

diff --git a/arches/app/src/components/ControlledListManager/LabelEditor.vue b/arches/app/src/components/ControlledListManager/LabelEditor.vue
@@ -8,6 +8,8 @@ import { deleteLabel } from "@/components/ControlledListManager/api.ts";
 import AddLabel from "@/components/ControlledListManager/AddLabel.vue";
 import LabelRow from "@/components/ControlledListManager/LabelRow.vue";
 
+import { ALT_LABEL, PREF_LABEL, URI } from "@/components/ControlledListManager/const.ts";
+
 import type {
     ControlledListItem,
     Label,
@@ -30,21 +32,21 @@ const slateBlue = "#2d3c4b"; // todo: import from theme somewhere
 
 const headings: { heading: string; subheading: string } = computed(() => {
     switch (props.type) {
-        case "prefLabel":
+        case PREF_LABEL:
             return {
                 heading: $gettext("Preferred Label(s)"),
                 subheading: $gettext(
                     "Provide at least one preferred label and language for your list item."
                 ),
             };
-        case "altLabel":
+        case ALT_LABEL:
             return {
                 heading: $gettext("Alternate Label(s)"),
                 subheading: $gettext(
                     "Optionally, you can provide additional label/language labels for your list item. Useful if you want to make searching for labels with synonyms or common misspellings of your preferred label(s) easier."
                 ),
             };
-        case "URI":
+        case URI:
             return {
                 heading: $gettext("List Item URI"),
                 subheading: $gettext(
@@ -84,7 +86,7 @@ const onDelete = async (label: Label) => {
             />
         </div>
         <AddLabel
-            v-if="type !== 'URI'"
+            v-if="type !== URI"
             :item
             :type="type"
             :on-insert

diff --git a/arches/app/src/components/ControlledListManager/LabelRow.vue b/arches/app/src/components/ControlledListManager/LabelRow.vue
@@ -3,6 +3,7 @@ import { computed, ref } from "vue";
 import { useGettext } from "vue3-gettext";
 
 import EditLabel from "@/components/ControlledListManager/EditLabel.vue";
+import { ALT_LABEL, PREF_LABEL } from "@/components/ControlledListManager/const.ts";
 
 import type { Label } from "@/types/ControlledListManager";
 
@@ -16,9 +17,9 @@ const modalVisible = ref(false);
 const { $gettext } = useGettext();
 const header = computed(() => {
     switch (props.label.valuetype) {
-        case "prefLabel":
+        case PREF_LABEL:
             return $gettext("Edit Preferred Label");
-        case "altLabel":
+        case ALT_LABEL:
             return $gettext("Edit Alternate Label");
         default:
             throw new Error();

diff --git a/arches/app/src/components/ControlledListManager/const.ts b/arches/app/src/components/ControlledListManager/const.ts
@@ -0,0 +1,3 @@
+const PREF_LABEL = "prefLabel";
+const ALT_LABEL = "altLabel";
+const URI = "URI";