Avoid an extra exists() query

archesproject · Nov 6, 2024 · 4f26c7f · 4f26c7f
1 parent b68ec6f
commit 4f26c7f
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/arches/app/models/graph.py b/arches/app/models/graph.py
@@ -2302,14 +2302,10 @@ def validate_fieldname(fieldname, fieldnames):
                 .filter(slug=self.slug)
             )
             if (
-                graphs_with_matching_slug.exists()
-                and graphs_with_matching_slug[0].graphid != self.graphid
-            ):
+                first_matching_graph := graphs_with_matching_slug.first()
+            ) and first_matching_graph.graphid != self.graphid:
                 if self.source_identifier_id:
-                    if (
-                        self.source_identifier_id
-                        != graphs_with_matching_slug[0].graphid
-                    ):
+                    if self.source_identifier_id != first_matching_graph.graphid:
                         raise GraphValidationError(
                             _(
                                 "Another resource model already uses the slug '{self.slug}'"