Upgrade controlled list manager to PrimeVue 4 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall this is looking good, but IMO the theming should be moved into dev/8.0.x, and logic should included that adds a css reset to all Vue components |
jacobtylerwalls
force-pushed
the
jtw/primevue-4
branch
from
65d0456
to
038f0c0
Compare
jacobtylerwalls
force-pushed
the
jtw/primevue-4
branch
from
8b47f1a
to
3754fb6
Compare
jacobtylerwalls
commented
Aug 9, 2024
Comment on lines
251
to
265
| export const shouldUseContrast = () => { | ||
| return Array.from(document.getElementsByTagName("link")).some((el) => | ||
| el.href.endsWith("accessibility.css"), | ||
| ); | ||
| }; |
There was a problem hiding this comment.
I expect we'll replace this with something better once we have infra around consuming system settings (i.e. ACCESSIBILITY_MODE).
There was a problem hiding this comment.
ya I'm wondering if this interaction can also be stubbed out in core at a very basic level as well, since the theme lives there now. We'll definitely use this across applications so if it can proved out in core instead, I think it'll be helpful.
There was a problem hiding this comment.
This was referenced Aug 12, 2024
jacobtylerwalls
commented
Aug 12, 2024
arches_references/templates/views/components/plugins/controlled-list-manager.htm
Outdated
Show resolved
Hide resolved
9 tasks
Depends on cssLayer: true in theme.ts
jacobtylerwalls
force-pushed
the
jtw/primevue-4
branch
from
7d2027b
to
f300f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details on a specific change, see the commit message.
Fixes #9
EDIT: now relies on the token theming in archesproject/arches#11262
EDIT: now relies on the accessibility mode change in archesproject/arches#11327