Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field schema to metadata and guarantee required fields #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aj-he
Copy link

@aj-he aj-he commented Nov 11, 2021

See issue #16 and #17

  • Ensured that the resourceinstanceid, tileid and nodeid properties are alway included to support the addin.
  • Added the fields to the meta data in the event that the layer is empty.

@aj-he
Copy link
Author

aj-he commented Nov 11, 2021

@robgaston @ryan86 could one of you review and assign me.

@aj-he
Copy link
Author

aj-he commented Nov 11, 2021

#17 is a blocking bug for the ESRI add-in testing

@aj-he aj-he self-assigned this Nov 11, 2021
@aj-he aj-he added the enhancement New feature or request label Nov 11, 2021
@aj-he aj-he requested a review from robgaston November 26, 2021 17:24
@aj-he aj-he assigned robgaston and unassigned aj-he May 6, 2022
@aj-he
Copy link
Author

aj-he commented May 6, 2022

Hi @robgaston this PR has been assigned to me rather than you for ages so I've changed it. We are not using it but the fix was sound so whenever you get a moment. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants