-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Artefact Type Certainty node #1281
base: dev/1.0.x
Are you sure you want to change the base?
Add Artefact Type Certainty node #1281
Conversation
@SDScandrettKint Working as expected in the UI. Just to check, this Artefact Type Certainty isn't expected to be displayed in the reports, is it? |
Thanks for spotting this @csmith-he, I forgot about adding it to the report! It has been added in the latest commit (855507a). I don't think it's necessary for it to have its own column, so I have added it in the "show details" part. |
Just to confirm from a functionality standpoint, I've managed to load our test cut of GLHER data into an instance of AfHERs with these changes in the models without any ill effects that I can see. From this point on, it just needs to be looked at by @Philbox now |
@SDScandrettKint Hang this off artefact type rather than production. Otherwise it's fine. |
@SDScandrettKint - Once you have changed the parent node of the new Artefact Type Certainty node as suggested by @Philbox, we can get this merged. |
As of 681a0f2, Artefact Type Certainty (+ metatype) have been moved under Artefact Type: Both Artefact Type Certainty and Artefact Type Certainty Metatype have the Ontology Class E55_Type and the relation to parent (Artefact Type) P2_has_type. Previously, Artefact Type Certainty had the relation of P141_assigned, but it is no longer available in the dropdown and hardcoding it in the model JSON causes errors |
@SDScandrettKint - I've asked @Philbox to take a look |
@SDScandrettKint the P141 assigned property is no longer true because that relates to the classification assignment. P2 has type is the correct property. So E55 Artefact Type -> P2 has type -> E55 Artefact Certainty Type This way the certainty type has a semantic relationship with Artefact Type and not any other node in the Phase Classification. |
Review on hold until graph changes discussed and agreed by group |
Addresses #1273
Adds Artefact Type Certainty and Artefact Type Certainty Metatype nodes on the same level as Artefact Type.
Resulting card looks as follows:
@Philbox Need I'm sunsure whether Phase Classification is the correct parent nodegroup for Artefact Type Certainty, or if you think Artefact Type would be a better parent for it?