Anticipate v8 breaking change to TileModel.nodegroup #1565
+20
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
force-pushed
the
jtw/v8-breaking
branch
from
e945153
to
86470f5
Compare
jacobtylerwalls
force-pushed
the
jtw/v8-breaking
branch
from
b42b297
to
05a1d81
Compare
jacobtylerwalls
force-pushed
the
jtw/v8-breaking
branch
from
b8f4331
to
19108e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of reviewing archesproject/arches#9613 I ran the AfS test suite, and found these breaking changes impacted.
We change change nodegroup -> nodegroup_id already in v7.6 without waiting for v8. This will make it easier to develop against either version.
Setting to DRAFT: there could be more that aren't covered by tests; need to grep the codebase.Also add DATABASES to test_settings so that it doesn't attempt to use the core arches test db. Might segregate out this change if this gets fixed in the app templates first.