Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ydrea #351

Open
wants to merge 1 commit into
base: 6.2
Choose a base branch
from
Open

Ydrea #351

wants to merge 1 commit into from

Conversation

ydrea
Copy link

@ydrea ydrea commented Jul 7, 2023

brief description of changes

I added some warnings, notes and links between chapters

further comments

Issues I ran into while cloning a 6.2.3 instance.


This box must be checked

  • [*] the PR branch was originally made from the base branch

This box should be checked

  • [*] after these changes the docs build locally without error

This box should only be checked you intend to follow through on it (we can do it on our end too)

  • [*] I will cherry-pick all commits in this PR into other branches that should have them after this PR is merged

@chiatt
Copy link
Member

chiatt commented Jul 9, 2023

Hi @ydrea thanks for this PR. Given the large number of commits and files changed, I suspect you didn't make your changes to a fork of master. That's not a problem as long as we know what branch you used. Do you recall which one it was?

@ydrea
Copy link
Author

ydrea commented Jul 10, 2023 via email

@ekansa ekansa changed the base branch from master to 6.2 July 12, 2023 22:08
@ekansa
Copy link
Collaborator

ekansa commented Jul 12, 2023

@ydrea I just returned from Europe so I'm sorry for the few days of lag in my response.

I just modified your PR so that it would merge into the 6.2 branch of this repo (https://github.com/archesproject/arches-docs/tree/6.2). It'll make it much easier to review and incorporate your enhancement.

@chiatt I see you commented here and were a suggested reviewer. But when I changed the base branch, it looks like my change removed the suggested reviewers! @ydrea if you could add suggested reviews again?

Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants