Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checks): invert logic of AVD-KCV-0030 #219

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

kapistka
Copy link
Contributor

We found an incorrect rego-expression when checking the parameter --encryption-provider-config

@kapistka kapistka requested a review from simar7 as a code owner August 20, 2024 08:19
@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024

CLA assistant check
All committers have signed the CLA.

@nikpivkin
Copy link
Contributor

Hi @kapistka! Nice catch

Can you update the tests?

@kapistka
Copy link
Contributor Author

Hi @kapistka! Nice catch

Can you update the tests?
done)

@nikpivkin
Copy link
Contributor

@kapistka Can you sign CLA? #219 (comment)

@kapistka
Copy link
Contributor Author

CLA done)

@kapistka
Copy link
Contributor Author

I can't understand why checks failed.

@nikpivkin
Copy link
Contributor

@kapistka Can you run make fmt-rego and push the changes?

@nikpivkin
Copy link
Contributor

@simar7 I've updated it, can you take a look?

@nikpivkin nikpivkin changed the title fix reverse logic --encryption-provider-config fix(checks): invert logic of AVD-KCV-0030 Sep 20, 2024
@simar7 simar7 added this pull request to the merge queue Sep 24, 2024
Merged via the queue into aquasecurity:main with commit e4defae Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants