Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): introduce events fallbacks #3965

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AlonZivony
Copy link
Contributor

@AlonZivony AlonZivony commented Apr 8, 2024

1. Explain what the PR does

Introduce the concept of events failure because of dependencies.
Add events the ability to declare a fallback dependencies, to be used upon failure.
This allows events to implement not necessarily supported implementation,
for new kernels for example, with other implementation to cover unsupported scenarios.

2. Explain how to test it

3. Other comments

@NDStrahilevitz
Copy link
Collaborator

IMO, if we're going by an approach where we can replace an entire set of dependency with another, then instead of having a recursive definition, each event should just have an array of definition so the map becomes map[events.ID][]EventDefinition. I think it would be slightly more readable, WDYT?

Introduce the concept of events failure because of dependencies.
Add events the ability to declare a fallback dependencies, to be used upon failure.
This allows events to implement not necessarily supported implementation,
for new kernels for example, with other implementation to cover unsupported scenarios.
@AlonZivony AlonZivony force-pushed the feature/fallback-dependencies-v2 branch from 05ceb49 to 739c1e6 Compare June 13, 2024 12:46
@AlonZivony AlonZivony marked this pull request as ready for review June 13, 2024 12:47
@AlonZivony
Copy link
Contributor Author

This PR is missing e2e tests.
We can have them by changing the current dependencies e2e tests, adding an event with failed dependencies and good fallback.
I fear I won't be able to do it now :(.

@AlonZivony AlonZivony force-pushed the feature/fallback-dependencies-v2 branch from 739c1e6 to f36a005 Compare June 13, 2024 12:51
@rscampos rscampos marked this pull request as draft September 24, 2024 15:16
@rscampos rscampos assigned rscampos and unassigned AlonZivony Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants