-
Notifications
You must be signed in to change notification settings - Fork 672
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into M/Aws/Api-gateway-v2-access-logging
- Loading branch information
Showing
57 changed files
with
4,403 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -306,5 +306,8 @@ module.exports = { | |
| }, | ||
| machineLearning: { | ||
| listWorkspaces: 'id' | ||
| }, | ||
| apiManagementService: { | ||
| list: 'id' | ||
| } | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| var async = require('async'); | ||
| var helpers = require('../../../helpers/aws'); | ||
|
|
||
| module.exports = { | ||
| title: 'API Gateway Request Validation', | ||
| category: 'API Gateway', | ||
| domain: 'Availability', | ||
| severity: 'Medium', | ||
| description: 'Ensures that Amazon API Gateway method has request validation enabled.', | ||
| more_info: 'Enabling request validation for API Gateway allows to perform basic validation of an API request before proceeding with the integration request and publishes the validation results in CloudWatch Logs. When request validation fails, API Gateway immediately fails the request reducing unnecessary calls to the backend.', | ||
| recommended_action: 'Modify API Gateway configuration and ensure that appropriate request validators are set for each API.', | ||
| link: 'https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-method-request-validation.html', | ||
| apis: ['APIGateway:getRestApis', 'APIGateway:getRequestValidators'], | ||
| realtime_triggers: ['apigateway:CreateRestApi','apigateway:DeleteRestApi','apigateway:ImportRestApi','apigateway:CreateRequestValidator','apigateway:UpdateRequestValidator','apigateway:DeleteRequestValidator'], | ||
|
|
||
| run: function(cache, settings, callback) { | ||
| var results = []; | ||
| var source = {}; | ||
| var regions = helpers.regions(settings); | ||
| var awsOrGov = helpers.defaultPartition(settings); | ||
|
|
||
| async.each(regions.apigateway, function(region, rcb){ | ||
| var getRestApis = helpers.addSource(cache, source, | ||
| ['apigateway', 'getRestApis', region]); | ||
|
|
||
| if (!getRestApis) return rcb(); | ||
|
|
||
| if (getRestApis.err || !getRestApis.data) { | ||
| helpers.addResult(results, 3, | ||
| `Unable to query for API Gateway Rest APIs: ${helpers.addError(getRestApis)}`, region); | ||
| return rcb(); | ||
| } | ||
|
|
||
| if (!getRestApis.data.length) { | ||
| helpers.addResult(results, 0, 'No API Gateway Rest APIs found', region); | ||
| return rcb(); | ||
| } | ||
|
|
||
| getRestApis.data.forEach(api => { | ||
| if (!api.id) return; | ||
|
|
||
| var apiArn = `arn:${awsOrGov}:apigateway:${region}::/restapis/${api.id}`; | ||
|
|
||
| var getRequestValidators = helpers.addSource(cache, source, | ||
| ['apigateway', 'getRequestValidators', region, api.id]); | ||
|
|
||
| if (!getRequestValidators || getRequestValidators.err || !getRequestValidators.data || !getRequestValidators.data.items) { | ||
| helpers.addResult(results, 3, | ||
| `Unable to query for API Gateway Request Validators: ${helpers.addError(getRequestValidators)}`, | ||
| region, apiArn); | ||
| return; | ||
| } | ||
|
|
||
| if (!getRequestValidators.data.items.length) { | ||
| helpers.addResult(results, 2, | ||
| 'No request validators found for API Gateway Rest API', | ||
| region, apiArn); | ||
| } else { | ||
| helpers.addResult(results, 0, | ||
| 'Request validators found for API Gateway Rest API', | ||
| region, apiArn); | ||
| } | ||
| }); | ||
|
|
||
| rcb(); | ||
| }, function() { | ||
| callback(null, results, source); | ||
| }); | ||
| } | ||
| }; | ||
|
|
||
|
|
Oops, something went wrong.