-
Notifications
You must be signed in to change notification settings - Fork 671
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2032 from AkhtarAmir/H-plugin/batch-account-manag…
…ed-identity Plugin Batch Account Managed Identity
- Loading branch information
Showing
3 changed files
with
151 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
plugins/azure/batchAccounts/batchAccountsManagedIdentity.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
var async = require('async'); | ||
var helpers = require('../../../helpers/azure/'); | ||
|
||
module.exports = { | ||
title: 'Batch Account Managed Identity', | ||
category: 'Batch', | ||
domain: 'Compute', | ||
severity: 'Medium', | ||
description: 'Ensures that Batch accounts have managed identity enabled.', | ||
more_info: 'Enabling managed identities eliminate the need for developers having to manage credentials by providing an identity for the Azure resource in Azure AD and using it to obtain Azure Active Directory (Azure AD) tokens.', | ||
recommended_action: 'Modify Batch Account and enable managed identity.', | ||
link: 'https://learn.microsoft.com/en-us/troubleshoot/azure/hpc/batch/use-managed-identities-azure-batch-account-pool', | ||
apis: ['batchAccounts:list'], | ||
realtime_triggers: ['microsoftbatch:batchaccounts:write','microsoftbatch:batchaccounts:delete'], | ||
|
||
run: function(cache, settings, callback) { | ||
var results = []; | ||
var source = {}; | ||
var locations = helpers.locations(settings.govcloud); | ||
|
||
async.each(locations.batchAccounts, function(location, rcb){ | ||
|
||
var batchAccounts = helpers.addSource(cache, source, | ||
['batchAccounts', 'list', location]); | ||
|
||
if (!batchAccounts) return rcb(); | ||
|
||
if (batchAccounts.err || !batchAccounts.data) { | ||
helpers.addResult(results, 3, 'Unable to query for Batch accounts: ' + helpers.addError(batchAccounts), location); | ||
return rcb(); | ||
} | ||
if (!batchAccounts.data.length) { | ||
helpers.addResult(results, 0, 'No existing Batch accounts found', location); | ||
return rcb(); | ||
} | ||
|
||
for (let batchAccount of batchAccounts.data) { | ||
if (!batchAccount.id) continue; | ||
|
||
if (batchAccount.identity && batchAccount.identity.type) { | ||
helpers.addResult(results, 0, 'Batch account has managed identity enabled', location, batchAccount.id); | ||
} else { | ||
helpers.addResult(results, 2, 'Batch account does not have managed identity enabled', location, batchAccount.id); | ||
} | ||
} | ||
|
||
rcb(); | ||
}, function() { | ||
callback(null, results, source); | ||
}); | ||
} | ||
}; |
98 changes: 98 additions & 0 deletions
98
plugins/azure/batchAccounts/batchAccountsManagedIdentity.spec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
|
||
var expect = require('chai').expect; | ||
var batchAccountsManagedIdentity = require('./batchAccountsManagedIdentity'); | ||
|
||
const batchAccounts = [ | ||
{ | ||
"id": "/subscriptions/1234566/resourceGroups/dummy/providers/Microsoft.Batch/batchAccounts/test", | ||
"name": "test", | ||
"type": "Microsoft.Batch/batchAccounts", | ||
"location": "eastus", | ||
"accountEndpoint": "test.eastus.batch.azure.com", | ||
"nodeManagementEndpoint": "123456789.eastus.service.batch.azure.com", | ||
"identity": { | ||
"principalId": "6bb43e0b-f260-4a69-ba3b-853b14451327", | ||
"tenantId": "d207c7bd-fcb1-4dd3-855a-cfd2f9b651e8", | ||
"type": "SystemAssigned", | ||
} | ||
}, | ||
{ | ||
"id": "/subscriptions/1234566/resourceGroups/dummy/providers/Microsoft.Batch/batchAccounts/test", | ||
"name": "test", | ||
"type": "Microsoft.Batch/batchAccounts", | ||
"location": "eastus", | ||
"accountEndpoint": "test.eastus.batch.azure.com", | ||
"nodeManagementEndpoint": "123456789.eastus.service.batch.azure.com", | ||
}, | ||
]; | ||
|
||
const createCache = (batchAccounts) => { | ||
return { | ||
batchAccounts: { | ||
list: { | ||
'eastus': { | ||
data: batchAccounts | ||
} | ||
} | ||
} | ||
} | ||
}; | ||
|
||
const createErrorCache = () => { | ||
return { | ||
batchAccounts: { | ||
list: { | ||
'eastus': {} | ||
} | ||
} | ||
}; | ||
}; | ||
|
||
describe('batchAccountsManagedIdentity', function () { | ||
describe('run', function () { | ||
|
||
it('should give unknown result if unable to query for Batch accounts:', function (done) { | ||
const cache = createCache(null); | ||
batchAccountsManagedIdentity.run(cache, {}, (err, results) => { | ||
expect(results.length).to.equal(1); | ||
expect(results[0].status).to.equal(3); | ||
expect(results[0].message).to.include('Unable to query for Batch accounts:'); | ||
expect(results[0].region).to.equal('eastus'); | ||
done(); | ||
}); | ||
}); | ||
|
||
it('should give passing result if no Batch account exist', function (done) { | ||
const cache = createCache([]); | ||
batchAccountsManagedIdentity.run(cache, {}, (err, results) => { | ||
expect(results.length).to.equal(1); | ||
expect(results[0].status).to.equal(0); | ||
expect(results[0].message).to.include('No existing Batch accounts found'); | ||
expect(results[0].region).to.equal('eastus'); | ||
done(); | ||
}); | ||
}); | ||
|
||
it('should give passing result if Batch account has managed identity enabled', function (done) { | ||
const cache = createCache([batchAccounts[0]]); | ||
batchAccountsManagedIdentity.run(cache, {}, (err, results) => { | ||
expect(results.length).to.equal(1); | ||
expect(results[0].status).to.equal(0); | ||
expect(results[0].message).to.include('Batch account has managed identity enabled'); | ||
expect(results[0].region).to.equal('eastus'); | ||
done(); | ||
}); | ||
}); | ||
|
||
it('should give failing result if Batch account does not have managed identity enabled', function (done) { | ||
const cache = createCache([batchAccounts[1]]); | ||
batchAccountsManagedIdentity.run(cache, {}, (err, results) => { | ||
expect(results.length).to.equal(1); | ||
expect(results[0].status).to.equal(2); | ||
expect(results[0].message).to.include('Batch account does not have managed identity enabled'); | ||
expect(results[0].region).to.equal('eastus'); | ||
done(); | ||
}); | ||
}); | ||
}); | ||
}); |