Migrate to GitHub Actions reusable workflows (2) #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
adopt_gha
branch
3 times, most recently
from
d1ae575
to
dd9e1bf
Compare
Motivation: Migrate to GitHub Actions reusable workflows (2) Modifications: * Add GHA PR label checks * Add GHA benchmarks checks * Satisfy soundness checks Result: New soundness checks should be green and ready for adoption
FranzBusch
reviewed
Oct 15, 2024
.github/workflows/pull_request.yml
Outdated
| docs_check_enabled: false | ||
| format_check_enabled: false | ||
| license_header_check_enabled: false | ||
| api_breakage_check_enabled: true |
There was a problem hiding this comment.
Can we remove all of these since true is the default
| timeout-minutes: 1 | ||
| steps: | ||
| - name: Checkout repository | ||
| if: ${{ !env.ACT }} |
There was a problem hiding this comment.
Should we move that into the semantic version action itself so we don't have to spread this if check everywhere?
There was a problem hiding this comment.
👍 removed for now and I'll open a PR in NIO
| @@ -60,28 +60,40 @@ We require that your commit messages match our template. The easiest way to do t | |||
|
|
|||
| git config commit.template dev/git.commit.template | |||
|
|
|||
| ### Run `./scripts/soundness.sh` | |||
| ### Run CI checks locally | |||
There was a problem hiding this comment.
Instead of putting this everywhere we can now link to https://github.com/swiftlang/github-workflows?tab=readme-ov-file#running-workflows-locally
FranzBusch
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare repo for new GHA checks.
(see #70)
Motivation:
Migrate to GitHub Actions reusable workflows
Modifications:
Result:
New soundness checks should be green and ready for adoption
Once this PR is merged we can: