Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test.pip compatible with Python 3.12 #2161

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

johnnynunez
Copy link

No description provided.

reqs/test.pip Outdated Show resolved Hide resolved
@TobyRoseman
Copy link
Collaborator

Additional changes will almost certainly be needed to support Python 3.12. Although PyTorch supports 3.12, TensorFlow doesn't curently support Python 3.12. I don't think it makes sense for us to move forward with support for a new version of Python until both PyTorch and TensorFlow supports it.

We're already tracking Python 3.12 support in #2129.

@johnnynunez
Copy link
Author

Additional changes will almost certainly be needed to support Python 3.12. Although PyTorch supports 3.12, TensorFlow doesn't curently support Python 3.12. I don't think it makes sense for us to move forward with support for a new version of Python until both PyTorch and TensorFlow supports it.

We're already tracking Python 3.12 support in #2129.

it's ready for tensorflow 2.16rc0. Only merge when tensorflow will be released

@johnnynunez
Copy link
Author

Additional changes will almost certainly be needed to support Python 3.12. Although PyTorch supports 3.12, TensorFlow doesn't curently support Python 3.12. I don't think it makes sense for us to move forward with support for a new version of Python until both PyTorch and TensorFlow supports it.

We're already tracking Python 3.12 support in #2129.

image https://pypi.org/project/tensorflow/

@johnnynunez
Copy link
Author

Warning: TensorFlow 2.15 included the final release of the tf-estimator
package. Estimators will not be available in TensorFlow 2.16 or after. See the
migration guide
for more information about how to convert off of Estimators.

@TobyRoseman
Copy link
Collaborator

CI run: https://gitlab.com/coremltools1/coremltools/-/pipelines/1211036648

@johnnynunez
Copy link
Author

CI run: https://gitlab.com/coremltools1/coremltools/-/pipelines/1211036648

it breaks because it tries to install tensorflow-macos. But on official apple page tells:
image

https://developer.apple.com/metal/tensorflow-plugin/

reqs/test.pip Outdated
@@ -38,7 +38,7 @@ tensorflow==2.16.1; platform_machine != "arm64"
keras==3.1.0; platform_machine != "arm64"

# TensorFlow (arm64) related package. Currently no Python 3.13 support.
tensorflow-macos==2.16.1; platform_machine == "arm64" and python_version < "3.13"
tensorflow==2.16.1; platform_machine == "arm64" and python_version < "3.13"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this makes sense. You probably want to remove this line and edit line 37 to covert both cases.

@TobyRoseman
Copy link
Collaborator

There also doesn't seem to be a Keras version 3.1: https://pypi.org/project/keras/#history
That also causing problems, example: https://gitlab.com/coremltools1/coremltools/-/jobs/6378720777

@TobyRoseman
Copy link
Collaborator

@TobyRoseman
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants