Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send op headers in introspection from here on out #7732

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mayakoneval
Copy link
Contributor

@mayakoneval mayakoneval commented Sep 22, 2023

We accept this flag in the embedded Sandbox code now, lets set it to false to address #7731

Also pin the most recent commit # on the embeddable Sandbox / Explorer repo so if we need to make a breaking change, we can version apollo/server

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit 30327b3
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/650def876b39eb0008a1960b
😎 Deploy Preview https://deploy-preview-7732--apollo-server-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 22, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 30327b3:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@mayakoneval mayakoneval requested review from glasser and a team as code owners September 22, 2023 00:28
Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit iffy to hand-modify inline snapshots but can we replace the commit hash with the interpolated constant as well? The tests will pass as the constant changes over time. Unfortunately if the snapshot updates (i.e. html changes for whatever reason) it'll overwrite our interpolated bit but not too worried about it.

Instead of pinning to a commit is there any way we could pin to a major version instead? So like, whenever sandbox is published, overwrite the v1 (or whatever major) in the cdn. It would be nice for AS users to get patches and minors quietly without the need for an AS update to be published.

Needs a changeset.

@@ -2912,7 +2912,7 @@ export function defineIntegrationTestSuiteApolloServerTests(
url = (await createServer(makeServerConfig([]))).url;
await get().expect(
200,
/embeddable-sandbox.cdn.apollographql.com\/_latest\/embeddable-sandbox.umd.production.min.js/s,
/embeddable-sandbox.cdn.apollographql.com\/17c6b43a4068da710c3713ec72f03dcb34bbd3de\/embeddable-sandbox.umd.production.min.js/s,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(my suggestion is missing an import)

Suggested change
/embeddable-sandbox.cdn.apollographql.com\/17c6b43a4068da710c3713ec72f03dcb34bbd3de\/embeddable-sandbox.umd.production.min.js/s,
new RegExp(`embeddable-sandbox.cdn.apollographql.com\/${DEFAULT_EMBED_VERSION}\/embeddable-sandbox.umd.production.min.js`, 's'),

@mayakoneval
Copy link
Contributor Author

Instead of pinning to a commit is there any way we could pin to a major version instead? So like, whenever sandbox is published, overwrite the v1 (or whatever major) in the cdn

The CDN assets are labelled by commit hash right now. We could map version to commit hash somewhere - maybe we can get that from github? Is this a request for now or later 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants