Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cancel upload by video id #17

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Shreedhar73
Copy link

The current cancelAll methods, cancels all the current uploads .

Implementation of Cancelling the Video Upload using the video ID. Useful when, a video object is created before starting the upload process.

1. Leveraged the cancel by videoID method already present on android side
2. Implemented cancel by videoID on IOS side
1. Gradle Distribution Url changed as per the latest main
2. js : Updated to 0.7.0 (as per the latest main)
@Shreedhar73 Shreedhar73 changed the title Feat/cancel upload by video Feat/cancel upload by video id Mar 4, 2024
@ThibaultBee
Copy link
Member

Hi there,
Thank you for your PR.

This PR concerns videoId that's mean you are using an API key in your application. Make sure you read https://docs.api.video/sdks/security#securing-the-api-keys-on-the-application-not-recommended before.
TL;DR: Don't use API key and videoId but use upload tokens.
For this reason, we probably won't merged it.

Now on your PR itself:

  • The Android implementation is good
  • The iOS implementation seems to be a little odd, storing a list where a lot of items could be blank value seems really strange. I think using a dictionnary would be a better implementation. It is also missing the progressive upload part.
  • The web implementation is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants