Upstream/2023 48 fix UI #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if legend label has long text, it will causing overflow issue - fixed it by adding Expanded in LegendPosition left and right ✨ feat: add prefix and suffix parameters in ChartValuesOptions - need this parameters in certain use case.
- this paramater was added to fix issue when legedPosition is right or left
apgapg
reviewed
Dec 30, 2023
| @@ -47,8 +47,8 @@ android { | |||
| applicationId "com.example.example" | |||
| // You can update the following values to match your application needs. | |||
| // For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-build-configuration. | |||
| minSdkVersion flutter.minSdkVersion | |||
| targetSdkVersion flutter.targetSdkVersion | |||
| minSdkVersion 28 | |||
There was a problem hiding this comment.
Are we sure we need to hardcode here?
@singhtaranjeet any insights?
There was a problem hiding this comment.
Yes it's fine to have it as hardcoded and it totally depends upon the requirements of the project but do we actually need to set it at 28 which is android 9?
Default of flutter 3.16 minSdkVersion is 19.
And Default of previous flutter version was android 16.
IMO we can go with flutter default as of now but in future if project requires then we can make the values hardcoded.
There was a problem hiding this comment.
@tajjacob any specific reason we changed this?
There was a problem hiding this comment.
@apgapg this one for my project. I can change it to default back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💄 ui: fix legend label overflow issue in LegendPosition left and right
💄 ui: fix legend label text lines in Legend
✨ parameter: add legendWidth parameter in LegendOptions
💄 ui: add separator in chartValue