Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2946] Fix wrong indent under of yunikornDefaults in service… #498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lshmouse
Copy link

@lshmouse lshmouse commented Oct 25, 2024

What is this PR for?

Fix wrong indent under of yunikornDefaults in https://yunikorn.apache.org/docs/user_guide/service_config

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2946

How should this be tested?

Screenshots (if appropriate)

image

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Comment on lines 404 to +406
queues:
- name: root
submitacl: '*'
- name: root
submitacl: '*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are using the do indent style(Link) in other places.
So I think we should change it to below:

  queues:
    - name: root
    submitacl: '*'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants