Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the k8shim-task-state image #496

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hiwangzhihui
Copy link
Contributor

What is this PR for?

Update the k8shim-task-state image
The k8shim-task-state of the TaskAllocated state doesn't exist in Version 1.1 to 1.6
[1.1 ~ 1.4] the k8shim-task-state is same
[1.5~1.6] the k8shim-task-state is same

What type of PR is it?

  • - Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2944

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - It needs update documentation.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't update the historical versions. They are auto-generated from the state machine as it existed in those versions. We keep the historical versions as-is for context.

@hiwangzhihui
Copy link
Contributor Author

Please don't update the historical versions. They are auto-generated from the state machine as it existed in those versions. We keep the historical versions as-is for context.
I checked the k8shim-task-state images from version 1.1 to 1.6 , and they are incorrect.
The images submitted in this PR are auto-generated based on the state machine for different versions.

@chenyulin0719
Copy link
Contributor

chenyulin0719 commented Oct 27, 2024

I checked the k8shim-task-state images from version 1.1 to 1.6 , and they are incorrect.
The images submitted in this PR are auto-generated based on the state machine for different versions.

Thanks for @hiwangzhihui 's check. We didn't check if the state image is up-to-date before each release, so I believe it's still worth fixing.

@craigcondit I understand that we don’t want to put extra effort into maintaining historical documents, but this correction could help prevent confusion for new developers. WDYT?

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Hi @hiwangzhihui, A small suggestion. We recommend that developers create pull requests from a feature branch instead of the master branch. (Doc)

@hiwangzhihui
Copy link
Contributor Author

I get it. Thanks for your reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants