-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the k8shim-task-state image #496
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't update the historical versions. They are auto-generated from the state machine as it existed in those versions. We keep the historical versions as-is for context.
|
Thanks for @hiwangzhihui 's check. We didn't check if the state image is up-to-date before each release, so I believe it's still worth fixing. @craigcondit I understand that we don’t want to put extra effort into maintaining historical documents, but this correction could help prevent confusion for new developers. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hi @hiwangzhihui, A small suggestion. We recommend that developers create pull requests from a feature branch instead of the master branch. (Doc)
I get it. Thanks for your reminder. |
What is this PR for?
Update the k8shim-task-state image
The k8shim-task-state of the TaskAllocated state doesn't exist in Version 1.1 to 1.6
[1.1 ~ 1.4] the k8shim-task-state is same
[1.5~1.6] the k8shim-task-state is same
What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2944
How should this be tested?
Screenshots (if appropriate)
Questions: