Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Dashboard): Native filters form update endpoint #30609

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

geido
Copy link
Member

@geido geido commented Oct 15, 2024

SUMMARY

This PR introduces a separate endpoint to store changes to the Native Filters form. Previously, the native filters form would attempt to save the filters even if no changes were made. The form was also sending the whole JSON object containing every individual filter, which caused unnecessary overhead. This PR does the following:

  • Sends a request to the new /filters endpoint only when changes are required
  • It sends only new or modified native filters
  • It sends only an ID reference for re-ordered or deleted filters

TESTING INSTRUCTIONS

  1. The native filters form should work normally

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added api Related to the REST API dashboard:native-filters Related to the native filters of the Dashboard labels Oct 15, 2024
@geido
Copy link
Member Author

geido commented Oct 17, 2024

/testenv up

Copy link
Contributor

@geido Ephemeral environment spinning up at http://35.87.197.94:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido requested a review from fisjac October 17, 2024 17:18
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Oct 18, 2024
@apache apache deleted a comment from github-actions bot Oct 18, 2024
@geido
Copy link
Member Author

geido commented Oct 18, 2024

/testenv up

Copy link
Contributor

@geido Ephemeral environment spinning up at http://35.161.33.58:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API dashboard:native-filters Related to the native filters of the Dashboard doc Namespace | Anything related to documentation size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants