-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Zeta] Support delete logs regularly #7787
base: dev
Are you sure you want to change the base?
Conversation
...rver/src/main/java/org/apache/seatunnel/engine/server/telemetry/log/TaskLogCleanService.java
Outdated
Show resolved
Hide resolved
...nector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/joblog/JobLogIT.java
Outdated
Show resolved
Hide resolved
...nnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/resources/seatunnel.yaml
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/seatunnel/engine/common/config/YamlSeaTunnelDomConfigProcessor.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/org/apache/seatunnel/engine/common/config/server/ServerConfigOptions.java
Outdated
Show resolved
Hide resolved
1d85e73
to
7704b1b
Compare
...nector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/joblog/JobLogIT.java
Outdated
Show resolved
Hide resolved
...unnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/org/apache/seatunnel/engine/server/telemetry/log/TaskLogCleanService.java
Outdated
Show resolved
Hide resolved
d888885
to
4516baf
Compare
link #7712 |
Thinks @corgy-w. Please fix the ci. |
In progress, but I don't know what went wrong. I've been looking for it. |
...er/src/main/java/org/apache/seatunnel/engine/server/telemetry/log/TaskLogManagerService.java
Outdated
Show resolved
Hide resolved
a67d14e
to
f22fc2b
Compare
...engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobHistoryService.java
Outdated
Show resolved
Hide resolved
...engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobHistoryService.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/seatunnel/engine/common/config/YamlSeaTunnelDomConfigProcessor.java
Show resolved
Hide resolved
This reverts commit de2bc94.
1eba760
to
b2ff484
Compare
# Conflicts: # seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/RestHttpGetCommandProcessor.java # seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/servlet/BaseServlet.java # seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/servlet/LogBaseServlet.java
...nnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/resources/seatunnel.yaml
Outdated
Show resolved
Hide resolved
...e/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/DAGUtils.java
Outdated
Show resolved
Hide resolved
for (Map.Entry<TaskGroupLocation, CompletableFuture<SlotProfile>> entry : | ||
preApplyResourceFutures.entrySet()) { | ||
try { | ||
Address worker = entry.getValue().get().getWorker(); | ||
historyExecutionPlan.add( | ||
new ExecutionAddress(worker.getHost(), worker.getPort())); | ||
|
||
} catch (Exception e) { | ||
LOGGER.warning("history execution plan add worker failed", e); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @zhangshenghang for a look.
log.warn(String.format("Log file path is empty, get logRef : %s", logRef)); | ||
return null; | ||
} | ||
return LogUtil.getLogPath(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if ci passes. Thanks @corgy-w !
docs/en/seatunnel-engine/logging.md
Outdated
history-job-expire-minutes: 1440 | ||
telemetry: | ||
logs: | ||
scheduled-deletion-enable: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this configuration be deleted? Keeping it as part of the job history information may cause disk accumulation.
cc @Hisoka-X
Purpose of this pull request
Delete logs regularly
For details, see logging.md
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.