[Improve] Binary transmission statistics #6946
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the count file size as the byte
|
Please open CI on your fork repository. |
|
Do I need to resubmit? |
|
|
Hisoka-X
reviewed
Jun 5, 2024
Comment on lines
+18
to
+41
| package org.apache.seatunnel.api.table.type; | ||
|
|
||
| public class BinaryRowType implements SeaTunnelDataType<BinaryRow> { | ||
|
|
||
| public static final BinaryRowType INSTANCE = new BinaryRowType(); | ||
|
|
||
| @Override | ||
| public Class<BinaryRow> getTypeClass() { | ||
| return BinaryRow.class; | ||
| } | ||
|
|
||
| @Override | ||
| public SqlType getSqlType() { | ||
| return SqlType.BINARY; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) { | ||
| if (obj == this) { | ||
| return true; | ||
| } | ||
| return obj instanceof PrimitiveByteArrayType; | ||
| } | ||
| } |
There was a problem hiding this comment.
When we add a new type, we have to be careful because it affects how all Sink/Transform should handle it. But the only purpose of this PR to add this new type is just to make the metrics more accurate, I think we need to discuss it in depth. cc @hailin0 @EricJoy2048
I think use metrics of zeta engine is feasible,Just adding an extra meaning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Count
counts the number of files (Excluding folders)
Bytes
counts the size of files (Excluding folders)
Example Results
Start Time : 2024-06-05 15:22:21
End Time : 2024-06-05 15:22:24
Total Time(s) : 2
Total Read Count : 4
Total Read Bytes : 3153492
Total Write Count : 4
Total Write Bytes : 3153492
Total Failed Count : 0