Skip to content

Commit

Permalink
[Improve][Zeta] Checkpoint exception status messages exclude state da…
Browse files Browse the repository at this point in the history
…ta (#5547)
  • Loading branch information
hailin0 authored Sep 25, 2023
1 parent f73b372 commit 865163d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
1 change: 1 addition & 0 deletions release-note.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@
- [Zeta] Cancel pipeline add retry to avoid cancel failed. (#4792)
- [Zeta] Improve Zeta operation max count and ignore NPE (#4787)
- [Zeta] Remove serialize(deserialize) cost when use shuffle action (#4722)
- [zeta] Checkpoint exception status messages exclude state data (#5547)

## Feature

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@

import lombok.Builder;
import lombok.Data;
import lombok.ToString;

@Data
@Builder
@ToString(exclude = "states")
public class PipelineState {

private String jobId;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public String storeCheckPoint(PipelineState state) throws CheckpointStorageExcep
datas = serializeCheckPointData(state);
} catch (IOException e) {
throw new CheckpointStorageException(
"Failed to serialize checkpoint data,state is :" + state, e);
String.format("Failed to serialize checkpoint data, state: %s", state), e);
}
Path filePath =
new Path(
Expand All @@ -108,7 +108,10 @@ public String storeCheckPoint(PipelineState state) throws CheckpointStorageExcep
out.write(datas);
} catch (IOException e) {
throw new CheckpointStorageException(
"Failed to write checkpoint data, state: " + state, e);
String.format(
"Failed to write checkpoint data, file: %s, state: %s",
tmpFilePath, state),
e);
}
try {
boolean success = fs.rename(tmpFilePath, filePath);
Expand Down

0 comments on commit 865163d

Please sign in to comment.