[fix][broker] Fix occur confusing error log when reader readEntry #23023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
reviewed
Oct 9, 2024
Comment on lines
530
to
531
| log.debug("[{}-{}] Error reading entries at {} : {} - Retrying to read in {} seconds", name, c, | ||
| cursor.getReadPosition(), exception.getMessage(), waitTimeMillis / 1000.0); |
There was a problem hiding this comment.
Is this debug log message correct? I don't think that there's a retry in this case.
There was a problem hiding this comment.
have changed the log message
lhotari
reviewed
Oct 12, 2024
| // since the next read operation would directly skip and finish. | ||
| // Just wait for a new NonDurableCursor open and read again. | ||
| if (cursor instanceof NonDurableCursorImpl) { | ||
| log.debug("[{}-{}] Error reading entries at {} : {}. " + |
There was a problem hiding this comment.
Please add if (log.isDebugEnabled()) { since exception.getMessage() could have a cost.
TakaHiR07
force-pushed
the
fix_error_log_in_readEntry
branch
from
f83a914
to
faba517
Compare
lhotari
approved these changes
Oct 12, 2024
lhotari
added
release/3.3.3
release/3.0.8
release/4.0.1
release/4.0.0
and removed
release/4.0.1
labels
|
Checkstyle error src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java:[547,76] (whitespace) OperatorWrap: '+' should be on a new line. |
|
It turns out that this is already covered by #22751. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Issue: #23022
Motivation
As shown in the issue. Fix occur confusing error log when use reader to read entry.
Modifications
In the case that read entry failed because cursor is NonDurableCursor and is closed , there is no need to trigger more read operations since the next read operation would directly skip and finish. Just wait for a new NonDurableCursor open and read again.
This is the simplest way I guess to fix the problem. This fix only affect the nonDurableCursor, which would not bring extra issue of durableCursor
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete