[fix][test] Fix memory leak via OTel shutdown hooks in tests

apache · Oct 18, 2024 · 7b59001 · 7b59001
1 parent 8de27a2
commit 7b59001
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/...dger/src/test/java/org/apache/bookkeeper/mledger/impl/cache/InflightReadsLimiterTest.java b/...dger/src/test/java/org/apache/bookkeeper/mledger/impl/cache/InflightReadsLimiterTest.java
@@ -206,6 +206,7 @@ public void testTooManyTrials() throws Exception {
  private Pair<OpenTelemetrySdk, InMemoryMetricReader> buildOpenTelemetryAndReader() {
  var metricReader = InMemoryMetricReader.create();
  var openTelemetry = AutoConfiguredOpenTelemetrySdk.builder()
+ .disableShutdownHook()
  .addMeterProviderCustomizer((builder, __) -> builder.registerMetricReader(metricReader))
  .build()
  .getOpenTelemetrySdk();

diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/BrokerOpenTelemetryTestUtil.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/BrokerOpenTelemetryTestUtil.java
@@ -35,6 +35,7 @@ public static Consumer<AutoConfiguredOpenTelemetrySdkBuilder> getOpenTelemetrySd
  return sdkBuilder -> {
  sdkBuilder.addMeterProviderCustomizer(
  (meterProviderBuilder, __) -> meterProviderBuilder.registerMetricReader(reader));
+ sdkBuilder.disableShutdownHook();
  sdkBuilder.addPropertiesSupplier(
  () -> Map.of(OpenTelemetryService.OTEL_SDK_DISABLED_KEY, "false",
  "otel.java.enabled.resource.providers", "none"));

diff --git a/...opentelemetry/src/test/java/org/apache/pulsar/opentelemetry/OpenTelemetryServiceTest.java b/...opentelemetry/src/test/java/org/apache/pulsar/opentelemetry/OpenTelemetryServiceTest.java
@@ -75,6 +75,7 @@ private static Consumer<AutoConfiguredOpenTelemetrySdkBuilder> getBuilderCustomi
  autoConfigurationCustomizer.addMeterProviderCustomizer(
  (sdkMeterProviderBuilder, __) -> sdkMeterProviderBuilder.registerMetricReader(extraReader));
  }
+ autoConfigurationCustomizer.disableShutdownHook();
  autoConfigurationCustomizer.addPropertiesSupplier(() -> extraProperties);
  };
  }