annotate some instrumented methods with @noinline #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems ok. @hughsimpson Can you link some of the broken Kamon tests or some general background as to what is fixed by this? |
|
@pjfanning pushed here. Test failures visible here |
pjfanning
approved these changes
Oct 10, 2024
|
Merged - a set of snapshot jars should be published to Apache Nexus tonight |
|
🙏 Thanks very much! |
|
@pjfanning this fixed the downstream tests, thanks again. Will cut a new Kamon release today, and eagerly await the next stable release of pekko-http so that we can all be happy and compatible 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar vein to apache/pekko#1489, this fixes Kamon instrumentation of http2 flows in pekko-http 1.1.+. (cf kamon-io/Kamon#1362 , which fails on https instrumentation tests)