Fix packages-public view function

[dorbae]

These changes make whisks.v.2.1/packges-public view function to check whether doc.binding is undfined before getting the length of it. It can prevent from CouchDB producing unnecessary logs.

Description

When 'packages-public' view builds the index, you can find these logs.

[info] 2024-09-07T02:25:38.312234Z nonode@nohost <0.1292.0> -------- OS Process #Port<0.8249> Log :: function raised exception (new TypeError("doc.binding is not an object", "undefined", 3)) with doc._id whisk.system/user25868/TEST

I modified 'isPublicPackage' function. I believe that use 'Falsy' because there's no need to check the length of doc.binding when it is not object type. And also, it's better to check Falsy or boolean before than the length of object.

// as-is
var isPublicPackage = functions(doc) {
    return Object.keys(doc.binding).length == 0 && doc.publish;
}

// to-be
var isPublicPackage = functions(doc) {
    return doc.binding && doc.publish && Object.keys(doc.binding).length == 0;
}

I confirmed that CouchDB 2.3.1 and 3.3.3 don't print it out during re-building the index.

Related issue and scope

• I opened an issue to propose and discuss this change (whisks.v2.1.0/packages-public view function logs 'new TypeError("doc.binding is not an object", "undefined", 3)' #5507 )

My changes affect the following components

• API
• Controller
• Message Bus (e.g., Kafka)
• Loadbalancer
• Scheduler
• Invoker
• Intrinsic actions (e.g., sequences, conductors)
• Data stores (e.g., CouchDB)
• Tests
• Deployment
• CLI
• General tooling
• Documentation

Types of changes

• Bug fix (generally a non-breaking change which closes an issue).
• Enhancement or new feature (adds new functionality).
• Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

• I signed an Apache CLA.
• I reviewed the style guides and followed the recommendations (Travis CI will check :).
• I added tests to cover my changes.
• My changes require further changes to the documentation.
• I updated the documentation where necessary.

[rabbah]

Thanks @dorbae for the fix