Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker login on invoker pods when using private registry #625

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

mluds
Copy link

@mluds mluds commented Jul 27, 2020

Actions that used a custom image from a private registry were failing, since the invoker containers weren't logged into the registry. This commit runs docker login in the invoker containers on startup to fix that.

@dgrove-oss
Copy link
Member

This looks reasonable to me. @mluds, please comment if you are done (not still working on this) and are ready for a potential merge. Do you have an Apache CLA on file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants