Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/ci/platforms/darwin.sh: Port NuttX CI Job to macOS-14 #14691

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

simbit18
Copy link
Contributor

@simbit18 simbit18 commented Nov 7, 2024

Summary

Now you can use any of these runners

macos-13
https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md

or

macos-14 (arm64)
https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md

added autoconf
needed to build kconfig_frontends on macos-14

bloaty
speeded build with cmake + ninja

if we upgrade to macos-14 we need to remember to clear the caches (macOS-tools-xxxxxxxx) first
https://github.com/apache/nuttx/actions/caches

Impact

Impact on user: No changes to user-facing functionality
Impact on build: Build process remains the same

Testing

tested only on github workflow with only [macos] because sim01, sim02, sim03 are broken !!!

macos-13
github macos-13

macos-14
github macos-14

@github-actions github-actions bot added Area: Tooling Area: CI Size: S The size of the change in this PR is small labels Nov 7, 2024
@simbit18
Copy link
Contributor Author

simbit18 commented Nov 7, 2024

Hi @lupyuen can you run a test on real macOS devices ?

@lupyuen
Copy link
Member

lupyuen commented Nov 7, 2024

@simbit18 I don't have an Intel Mac though. This will work on M1 Mac?

@simbit18
Copy link
Contributor Author

simbit18 commented Nov 7, 2024

macos-14 Today, GitHub is excited to announce the launch of a new M1 macOS runner!
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

@lupyuen lupyuen linked an issue Nov 7, 2024 that may be closed by this pull request
1 task
@lupyuen
Copy link
Member

lupyuen commented Nov 7, 2024

Thanks @simbit18! On my Mac Mini M2 Pro, it fails while building gperf:

g++ -g -O2 -I. -I./../lib -c ./main.cc
g++ -g -O2  -o gperf version.o positions.o options.o keyword.o keyword-list.o input.o bool-array.o hash-table.o search.o output.o main.o ../lib/libgp.a -lm
ld: archive member '/' not a mach-o file in '/Users/luppy/simbit18-macos-arm64/tools/gperf-3.1/lib/libgp.a'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

https://gist.github.com/lupyuen/9e49ad8f91e2f2e9b76c41eb583664d9

@simbit18
Copy link
Contributor Author

simbit18 commented Nov 7, 2024

@lupyuen maybe related to this ?
https://stackoverflow.com/a/77630733

I see this is a common problem :)
https://forums.developer.apple.com/forums/thread/741149

possible solution
pyenv/pyenv#2862

@xiaoxiang781216 xiaoxiang781216 merged commit 5080ab7 into apache:master Nov 7, 2024
26 of 27 checks passed
@lupyuen
Copy link
Member

lupyuen commented Nov 7, 2024

I just restarted the job so it will pick up the fix from apache/nuttx-apps#2829. And it won't run all 6 hours :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Area: Tooling Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Porting NuttX CI Job from Intel Mac to Apple Silicon Mac
3 participants