Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/arm64/imx9/imx93-evk: add trdc header #14687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joukkone
Copy link
Contributor

@joukkone joukkone commented Nov 7, 2024

Example trdc header for bootloader build

This is needed when building bootloader for imx9-evk

Note: Please adhere to Contributing Guidelines.

Summary

Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.

Impact

Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.

Testing

Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.

Example trdc header for bootloader build

Signed-off-by: Jouni Ukkonen <[email protected]>
@github-actions github-actions bot added Board: arm64 Size: M The size of the change in this PR is medium labels Nov 7, 2024
@nuttxpr
Copy link

nuttxpr commented Nov 7, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements. While it provides the template, it lacks the crucial information required by the template. Specifically, the sections marked with "Update this section..." are placeholders and haven't been filled with the actual details of the change. A PR with these placeholders is incomplete and unreviewable.

Here's a breakdown of what's missing:

  • Summary: The summary needs to explain the why, what, and how of the change. It mentions a trdc header for the imx9-evk bootloader, but doesn't explain why this header is needed, what it contains, or how it solves the problem. There's no mention of related issues.

  • Impact: All the impact fields are left blank. The author needs to assess and document the impact of the change on users, build process, hardware, documentation, security, and compatibility.

  • Testing: The testing section is also incomplete. It requests details about the build host and target, as well as logs from before and after the change, but none of this information is provided. Simply stating "This is needed" isn't sufficient verification.

To meet the NuttX requirements, the author needs to fill out all the required sections with specific information relevant to the changes made.

@acassis
Copy link
Contributor

acassis commented Nov 7, 2024

Hi @joukkone nice contribution! Please include later a board config and a Documentation/ explaining how to use the bootloader on this board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Board: arm64 Size: M The size of the change in this PR is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants