-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smpcall: we directly call the function to handle local smpcall #14663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: OS Components
OS Components issues
Size: S
The size of the change in this PR is small
labels
Nov 6, 2024
hujun260
added a commit
to hujun260/nuttx
that referenced
this pull request
Nov 6, 2024
reason: some arch do not support issuing interrupts to the local CPU. This commit fixes the regression from apache#14663 Signed-off-by: hujun5 <[email protected]>
[Experimental Bot, please feedback here] This PR appears to mostly meet the NuttX requirements, but is missing some key information. Here's a breakdown: Strengths:
Weaknesses:
Recommendation: To fully meet the NuttX requirements, the PR needs to:
By addressing these points, the PR will be much stronger and easier for reviewers to evaluate. |
hujun260
added a commit
to hujun260/nuttx
that referenced
this pull request
Nov 6, 2024
reason: some arch do not support issuing interrupts to the local CPU. This commit fixes the regression from apache#14663 Signed-off-by: hujun5 <[email protected]>
reason: some arch do not support issuing interrupts to the local CPU. This commit fixes the regression from apache#14663 Signed-off-by: hujun5 <[email protected]>
xiaoxiang781216
approved these changes
Nov 6, 2024
@masayuki2009 could you verify this patch whether fix your problem? |
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
smpcall: we directly call the function to handle local smpcall
some arch do not support issuing interrupts to the local CPU.
This commit fixes the regression from #14656
Impact
smpcall
Testing
ci ostest
Build Host:
Configuring NuttX and compile:
$ ./tools/configure.sh -l qemu-armv8a:nsh_smp
$ make
Running with qemu
$ qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic
-machine virt,virtualization=on,gic-version=3
-net none -chardev stdio,id=con,mux=on -serial chardev:con
-mon chardev=con,mode=readline -kernel ./nuttx