fix macos sim nsh break, fix missing ops in psedofile_ops, fix no -mcmodel=medium in clang. #14606
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: File System
jasonbu
force-pushed
the
macos_fix_sim_nsh_break
branch
from
2200c07
to
f291450
Compare
github-actions
bot
added
Size: S
Will cause sim:nsh break in macos environment, the fs_psedofile missing ops update Signed-off-by: buxiasen <[email protected]>
Will report clang: error: invalid argument 'medium' to -mcmodel= -mcmodel=large will both support clang and gcc. Signed-off-by: buxiasen <[email protected]>
jasonbu
force-pushed
the
macos_fix_sim_nsh_break
branch
from
f291450
to
e4e0cf2
Compare
github-actions
bot
added
Size: XS
|
Hi @jasonbu are there any updates on this PR ? macos workflow is broken |
hi, in my patch, msvc failed, and recent days don't have time verfy the mscv CI report issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
after this patch #13498, we add new
in struct file_operations.
but
static const struct file_operations g_pseudofile_ops
did not update, as there is a pseudofile_unlink in last ops.
case sim:nsh break.
after #14466, add -mcmodel=medium witch is not supported in clang.
-mcmodel=large, should both support gcc & clang.
case sim:nsh break in makefile.
Impact
change from -mcmodel=medium to -mcmodel=large maybe cause larger codesize? not sure if it's a critical index.
sim:nsh in macos will ready to work with both make and cmake after fix.
Testing
ci-test, local macos with cmake sim:nsh & makefile sim:nsh.