Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nucleo-H563ZI with NSH configuration #14583

Closed
wants to merge 1 commit into from

Conversation

stbenn
Copy link
Contributor

@stbenn stbenn commented Oct 31, 2024

Created stm32h5 directory to add support for the H5 chip, and used a Nucleo-H563ZI dev board during development. The goal was to get a working nutshell through the STLink connector on the board.

Code contained in PR was written in collaboration with @kywwilson11.

Note: Please adhere to Contributing Guidelines.

Summary

There has not been support for STM32H5 chips, so this should provide a starting point for further development. Being able to get to a nutshell on a dev board seems like a good first step.

Impact

Testing

Testing was done by building the configuration, programming the board and seeing the characters printed during start, followed by nsh> working.

OS: Ubuntu 24.04 (Running in WSL2 on Windows 11)
Compiler: arm-none-eabi-gcc (15:13.2.rel1-2) 13.2.1 20231009
Target:

  • Arch: STM32H5
  • Chip: STM32H563ZIT6U
  • Board: Nucleo-H563ZI
  • Config: nucleo-h563zi:nsh config (added by this PR)

@github-actions github-actions bot added Area: Documentation Improvements or additions to documentation Arch: arm Issues related to ARM (32-bit) architecture Board: arm labels Oct 31, 2024
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added the Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. label Oct 31, 2024
@stbenn
Copy link
Contributor Author

stbenn commented Oct 31, 2024

If this PR needs to be broken up into smaller components, please advise on what components would make the most sense as the first step in the process.

@acassis
Copy link
Contributor

acassis commented Nov 1, 2024

@stbenn there is not fixed rule. You can create an initial commit that add the new arch with the headers files, then the peripherals and later on the board support

@stbenn
Copy link
Contributor Author

stbenn commented Nov 1, 2024

@acassis Would you suggest closing this PR to do that then? The main reason this PR was so large is because we wanted to get the H5 to a point you could actually do something with it (nutshell).

@acassis
Copy link
Contributor

acassis commented Nov 1, 2024

@acassis Would you suggest closing this PR to do that then? The main reason this PR was so large is because we wanted to get the H5 to a point you could actually do something with it (nutshell).

It is up to you, it is possible to create new commit and use git push forced to update your PR

@github-actions github-actions bot removed Area: Documentation Improvements or additions to documentation Board: arm labels Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Created stm32h5 directory to add support for the H5 chip, and used a Nucleo-H563ZI dev board during development. The goal was to get a working nutshell through the STLink connector on the board.

Remove board/docs changes for PR update

delete more files

Remove and rename more files.
Copy link

github-actions bot commented Nov 1, 2024

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@stbenn stbenn closed this Nov 1, 2024
@stbenn stbenn deleted the Nucleo-H563ZI_NSH branch November 1, 2024 17:59
@cederom
Copy link
Contributor

cederom commented Nov 2, 2024

Thank you @stbenn !! Great work, and most welcome! However, as @acassis mentioned it is better to include this kind of change in small parts, so we can test integration step by step and pinpoint / fix possible problems that arise during build on various platforms and configurations :-)

@cederom
Copy link
Contributor

cederom commented Nov 2, 2024

On the other hand if all builds and works fine splitting that big change is a lot of additional work and may result in additional problems :-P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: arm Issues related to ARM (32-bit) architecture Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants