Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc migration 4 #14522

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Doc migration 4 #14522

merged 4 commits into from
Oct 28, 2024

Conversation

lvanasse
Copy link
Contributor

Summary

Migrate pages:

  • Signaling Events from Interrupt Handlers
  • Signaling Semaphores and priority inheritance
  • Smaller Vector Tables

Impact

None, only update documentation

Testing

Build with make autobuild

@lvanasse
Doc: Migrate Signaling Events from Interrupt Handlers doc
dd11e16 
Migrate
https://cwiki.apache.org/confluence/display/NUTTX/Signaling+Events+from+Interrupt+Handlers
to official wiki

Signed-off-by: Ludovic Vanasse <[email protected]>
@lvanasse
Doc: Migration Signaling Semaphores and priority inheritance
e4f5465 
Migrate
https://cwiki.apache.org/confluence/display/NUTTX/Signaling+Semaphores+and+Priority+Inheritance
to official wiki

Signed-off-by: Ludovic Vanasse <[email protected]>
@lvanasse
Doc: Replace link from old wiki to new wiki in signaling events from int
834e6cc 
Signed-off-by: Ludovic Vanasse <[email protected]>
@lvanasse
Doc: Migrate Smaller Vector Tables
00802d2 
Migrate
https://cwiki.apache.org/confluence/display/NUTTX/Smaller+Vector+Tables
to official wiki

Signed-off-by: Ludovic Vanasse <[email protected]>
@github-actions github-actions bot added Area: Documentation Improvements or additions to documentation Size: L The size of the change in this PR is large labels Oct 27, 2024
@lvanasse lvanasse mentioned this pull request Oct 27, 2024
Open
100 tasks
@nuttxpr
Copy link

nuttxpr commented Oct 27, 2024

[Experimental Bot, please feedback here]

Yes, this PR appears to meet the NuttX requirements.

Here's why:

  • Summary: Clearly outlines the "what" (migrating specific documentation pages) and the "why" (assumedly for organization or clarity).
  • Impact: Accurately identifies the impact as purely documentation-related with no functional code changes.
  • Testing: While make autobuild is mentioned, providing snippets of build logs (even if just "build succeeded" messages) would further strengthen the testing confirmation.

Minor Suggestion:

  • Consider adding a brief statement in the "Summary" about where these pages are being migrated to. This enhances clarity for reviewers.

@xiaoxiang781216 xiaoxiang781216 merged commit 2c2a794 into apache:master Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerpelea jerpelea jerpelea approved these changes

Assignees
No one assigned
Labels
Area: Documentation Improvements or additions to documentation Size: L The size of the change in this PR is large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lvanasse @nuttxpr @jerpelea @xiaoxiang781216