-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/note: move the note formatting code from trace_dump into noteram_drivers.c #10124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gary-Hobson
changed the title
Noteram
drivers/note: moves the note formatting code from trace_dump into noteram_drivers.c
Aug 9, 2023
Gary-Hobson
changed the title
drivers/note: moves the note formatting code from trace_dump into noteram_drivers.c
drivers/note: move the note formatting code from trace_dump into noteram_drivers.c
Aug 9, 2023
acassis
approved these changes
Aug 9, 2023
jerpelea
approved these changes
Aug 9, 2023
Please fix this error in the nuttx-apps:
|
Signed-off-by: yinshengkai <[email protected]>
Signed-off-by: yinshengkai <[email protected]>
Signed-off-by: yinshengkai <[email protected]>
Signed-off-by: yinshengkai <[email protected]>
Signed-off-by: yinshengkai <[email protected]>
syscall cannot be called in syscall, if this happens, it should be fixed (interruption is similar) Signed-off-by: yinshengkai <[email protected]>
Signed-off-by: yinshengkai <[email protected]>
I've already fixed the error in the nuttx-apps:apache/nuttx-apps#1942 |
xiaoxiang781216
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the note formatting code from trace_dump into noteram and simplifies the noteram code.
Details:
Change 1: move trace_dump to noteram_driver.c
Change 2: replace the spaces in the name in tcb, there cannot be spaces in the thread name in atrace format
Change 3: remove task_context and get_taskname related code, we don't need it anymore
Change 4: simplify the logic of ringbuffer in noteram
Impact
The data returned by reading the /dev/note device is no longer binary data, but a formatted string, and it will only return one note record each time it is read
Testing
self-test + internal CI