Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing/fatutf8:fix Out of bounds writing #2782

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

xiaoxiang781216
Copy link
Contributor

Summary

fix coverity bug

Impact

minor fix

Testing

ci

@nuttxpr
Copy link

nuttxpr commented Oct 27, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • Lacks a clear explanation of the bug and the solution. What specifically was the Coverity issue (e.g., resource leak, potential null pointer dereference)? How was it fixed? Which part of the codebase was affected?
  • Impact:
    • "Minor fix" is too vague. While it might be minor, specify potential areas of impact. Does this fix affect any specific architectures, drivers, or configurations? Even if the answer is no to most impact questions, state that explicitly.
  • Testing:
    • "ci" is insufficient. Provide:
      • Specific build hosts used (OS, CPU architecture, compiler version).
      • Specific target platforms tested (architecture, board, configuration).
      • Relevant snippets of testing logs (ideally showing the issue before and the resolution after the fix).

Example of an Improved Summary:

This PR resolves a Coverity-flagged resource leak in the I2C driver for the STM32F4 family. The issue occurred when an I2C transfer was aborted prematurely, failing to release a mutex. The fix ensures the mutex is always released, even in error conditions.

@GUIDINGLI GUIDINGLI merged commit df559f1 into apache:master Oct 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants