Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example/libtest: add malloc/free to libtest #2775

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

XuNeo
Copy link
Contributor

@XuNeo XuNeo commented Oct 26, 2024

Summary

So we can verify flags like kasan are effective or not.

Impact

Minor

Testing

Compile libtest and disassemble library_test to verify kasan is actually used.

@nuttxpr
Copy link

nuttxpr commented Oct 26, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • The summary is too vague. It doesn't explain:
      • Why is the change necessary? What problem does it solve?
      • What functional part of the code is being changed? Be specific.
      • How does the change work? Provide technical details.
    • Include any relevant issue references.
  • Impact:
    • Minor is not descriptive enough.
    • Address all impact points with specific details (even if the answer is NO).
  • Testing:
    • Insufficient detail:
      • Specify the exact build hosts (OS, CPU, compiler versions) and targets (arch, board, config) used.
      • Provide complete and meaningful testing logs. "Compile libtest" and "disassemble library_test" are not informative enough.

Recommendations:

  1. Expand the Summary: Provide a clear and detailed explanation of the problem, the solution, and how it works.
  2. Address All Impact Points: Go through each impact category and provide a specific answer, even if it's "NO." Explain any "YES" answers thoroughly.
  3. Provide Detailed Testing Information: List all build hosts and targets used, and include complete and relevant testing logs that demonstrate the change's functionality.

examples/libtest/libtest.c Outdated Show resolved Hide resolved
examples/libtest/libtest.c Outdated Show resolved Hide resolved
So we can verify flags like kasan are effective or not.

Signed-off-by: xuxingliang <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 28c3c05 into apache:master Oct 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants