Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Split the Build Jobs for Arm64 and x86_64 #2760

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

lupyuen
Copy link
Member

@lupyuen lupyuen commented Oct 20, 2024

Summary

This PR syncs apache/nuttx#14282 from nuttx repo to nuttx-apps.

Impact

See apache/nuttx#14282

Testing

See apache/nuttx#14282

This PR syncs apache/nuttx#14282 from `nuttx` repo to `nuttx-apps`.
@nuttxpr
Copy link

nuttxpr commented Oct 20, 2024

[Experimental Bot, please feedback here]

Yes, but with minor improvements:

While concise, referencing the original PR for Impact and Testing might make reviewers jump between PRs. It's better to summarize key points directly:

Improved Summary:

  • Why: Keeps nuttx-apps in sync with the latest changes in nuttx (referencing the specific fix/feature from PR #14282).
  • What: Syncs the changes introduced in nuttx PR #14282.
  • How: Direct code synchronization.

Improved Impact:

  • Briefly list the actual impact points from PR #14282, e.g., "Adds new feature X", "Affects ARM boards", "Requires documentation updates".

Improved Testing:

  • Instead of "See #14282", briefly state:
    • IF testing in nuttx-apps is identical to nuttx: "Testing unchanged, see #14282 for details".
    • IF there are nuttx-apps specific tests: Include a concise summary of those results.

By making these sections self-contained, you improve the review experience and reduce back-and-forth.

@xiaoxiang781216 xiaoxiang781216 merged commit 52a50ea into apache:master Oct 20, 2024
24 checks passed
@lupyuen lupyuen linked an issue Oct 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[URGENT] Reducing our usage of GitHub Runners
3 participants